Page 1 of 1

Undocumented dialog component

Posted: 01 November 2020, 18:48
by Inaofr
Hi,

While fixing a bug on a Stone Age dialog, I realized that the used dialog was not documented in BGA doc. The doc is describing the use of ebg.popindialog (see http://en.doc.boardgamearena.com/Game_i ... js#Dialogs), while the legacy code I have in Stone Age is using dijit.Dialog.
Does someone know if there is a reason for dijit.Dialog being not documented? Should I change Stone Age code to use ebg.popindialog instead?

Re: Undocumented dialog component

Posted: 01 November 2020, 21:55
by Victoria_La
Wiki changed last year Check wiki history it was documented there (March 2019), its raw dialog using framework method directly.
You can probably google API to dijit.Dialog its not propriatory.
(old wiki revision https://en.doc.boardgamearena.com/index ... 13#Dialogs)

Re: Undocumented dialog component

Posted: 01 November 2020, 22:59
by Inaofr
OK, thanks, I wasn't aware dijit was part of the dojo framework.
It is Een, an admin, who replaced the doc for dijit.Dialog by the doc of ebg.popindialog, so my guess is the later should be preferred.

Re: Undocumented dialog component

Posted: 02 November 2020, 16:12
by Een
Yes, we used dijit.Dialog before, but wanted to do better, and created ebg.popindialog.

New games should use ebg.popindialog, and for older games using dijit.Dialog, we have an overload replacing it by ebg.popindialog (so visually in the games, it's always ebg.popindialog)