Page 1 of 1

[SOLVED] Is disable player swap on rematch implemented?

Posted: 28 November 2020, 17:14
by Woodruff
Hi everybody,

I set the flag to disable player swap on rematch for two games on production because it is not relevant for these:

Code: Select all

// In gameinfos.inc.php

// When doing a rematch, the player order is swapped using a "rotation" so the starting player is not the same
// If you want to disable this, set this to false
'disable_player_order_swap_on_rematch' => false,
Yet, I see that there is still that swap occurring and it is confirmed by the log.

Is that mechanism not yet implemented in the BGA framework and for the moment that flag is ignored?
Or is it working and I made a syntax error somewhere?

To discard one possible trivial issue, I did reload the game information using the button in the control panel before building a version for release.

What is your experience with this?
Thanks a lot :)
Take care,

Woodruff

Re: Is disable player swap on rematch implemented?

Posted: 29 November 2020, 11:21
by Een
This is implemented, and used for Seven Wonders so it should definitely work.

Re: Is disable player swap on rematch implemented?

Posted: 29 November 2020, 11:22
by Een
But the comment is wrong. It has to be set to true (maybe that's the issue there?)

[SOLVED] Is disable player swap on rematch implemented?

Posted: 29 November 2020, 14:47
by Woodruff
Een wrote: 29 November 2020, 11:22 But the comment is wrong. It has to be set to true (maybe that's the issue there?)
Ah OK :D
Yes, that is the comment in the souce code (auto-generated if I recall well).
Thanks for the quick solve!