improved error message

[ddyer]

"This game action is impossible right now".

Presumably this comes from "checkaction" and it would be trivial to mention the action name
and perhaps the current game state.

[ddyer]

likewise for "Unexpected error: Not a player action"

[Een]

Hi,

Taking a look at this (finally). in fact, this message is not meant for debugging as it can be presented to the user. That's why it's generic, as action and state name are developper stuff that shouldn't show on the surface.
There is currently already a message in the log with all the information needed for debugging purposes :

Code: Select all

self::trace( "Game action impossible: ".$action_name." for state ".$state['name'] );

As for the second error, I couldn't find it in the source, so it must have been rewritten already.

Cheers,
Een