regression in the framework?

[Jeromie]

Hello,

Since this morning I'm seeing multiple bug reports that clans of caledonia games cannot be completed
https://boardgamearena.com/bug?id=183650
https://boardgamearena.com/bug?id=183678
https://boardgamearena.com/bug?id=183704
https://boardgamearena.com/bug?id=183706

So I've tried a solo game and indeed it gives an error 500:

Code: Select all

XHRGET
https://boardgamearena.com/14/clansofcaledonia/clansofcaledonia/pass.html?price=-16&price_token=0&lock=f4900dc8-c60d-4aca-8b2b-959f777d3fb1&table=727825922&noerrortracking=true&dojo.preventCache=1757512634783
[HTTP/2 500  173ms]

HTTP code 500 clansofcaledonia/clansofcaledonia/pass.html index.js:1:68315
Object { message: "Unable to load clansofcaledonia/clansofcaledonia/pass.html?price=-16&price_token=0&lock=f4900dc8-c60d-4aca-8b2b-959f777d3fb1&table=727825922&noerrortracking=true&dojo.preventCache=1757512634783 status: 500", response: {…}, status: 500, responseText: "", xhr: XMLHttpRequest, stack: "", … }
index.js:1:68315

Our last release is from a week ago and it was working fine since, I don't feel equipped to troubleshoot this.

I'm seeing reports in other game saying that similar issues have been fixed for them, and it seems to have started since the latest BGA release: viewtopic.php?p=225858#p225858

Does someone know what's going on?

[thoun]

Here is what I wrote on the dev discord :

It seems the last release broke a few games.
Mainly those accessing `$this->gamestate->states` even if it's undocumented
A quick fix is `$this->gamestate->getStatesAsArray()` to get the array as before (because now it's internally state objects and not state arrays)
But the best is to not access it. If you need to, please explain me why.

[Jeromie]

I'm not seeing any call to `states` in the code base after a quick look, could the BGA update be rolled back or patched for retro-compatibility?

1. No clans of caledonia game can be completed in the current state
2. I have no idea how to investigate/fix the issue, I've inherited the code base and trying my best but there's not even a clear error message I can work with
3. I'm in the middle of a move IRL, I can't deal with this with the urgency it requires

If it's not an option then I someone from BGA should make the fix in the game ASAP.

[thoun]

I'll look at it then.

Edit: it should be fixed now.